From db1c2e40416ac1add2e9d10de4c87c4c5a3d8bf2 Mon Sep 17 00:00:00 2001 From: Roland Haeder Date: Thu, 23 Mar 2017 23:37:58 +0100 Subject: [PATCH] fixed comment and explained one Signed-off-by: Roland Haeder --- include/dfrn.php | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/include/dfrn.php b/include/dfrn.php index 34cd33c33..9413b4d3a 100644 --- a/include/dfrn.php +++ b/include/dfrn.php @@ -1637,7 +1637,13 @@ class dfrn { intval($fid) ); - /// @TODO Really abort on valid result??? Maybe missed ! here? + /* + * The valid result means the friend we're about to send a friend + * suggestion already has them in their contact, which means no further + * action is required. + * + * @see https://github.com/friendica/friendica/pull/3254#discussion_r107315246 + */ if (dbm::is_result($r)) { return false; } @@ -1656,7 +1662,10 @@ class dfrn { dbesc($suggest["request"]) ); - // This way a useless else-block is being spared, resulting in easier code. + /* + * If no record in fcontact is found, below INSERT statement will not + * link an introduction to it. + */ if (!dbm::is_result($r)) { // database record did not get created. Quietly give up. killme();