From b5fa5189989dace50ac819cb169344d1134e1fdf Mon Sep 17 00:00:00 2001 From: Michael Date: Tue, 13 Nov 2018 05:52:21 +0000 Subject: [PATCH 1/2] Don't suggest hidden contacts / Added AP to the suggestions --- mod/dirfind.php | 8 ++++---- src/Model/GContact.php | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mod/dirfind.php b/mod/dirfind.php index d3298b64d..2609760e9 100644 --- a/mod/dirfind.php +++ b/mod/dirfind.php @@ -121,23 +121,23 @@ function dirfind_content(App $a, $prefix = "") { /// @TODO These 2 SELECTs are not checked on validity with DBA::isResult() $count = q("SELECT count(*) AS `total` FROM `gcontact` - WHERE NOT `hide` AND `network` IN ('%s', '%s', '%s') AND + WHERE NOT `hide` AND `network` IN ('%s', '%s', '%s', '%s') AND ((`last_contact` >= `last_failure`) OR (`updated` >= `last_failure`)) AND (`url` LIKE '%s' OR `name` LIKE '%s' OR `location` LIKE '%s' OR `addr` LIKE '%s' OR `about` LIKE '%s' OR `keywords` LIKE '%s') $extra_sql", - DBA::escape(Protocol::DFRN), DBA::escape($ostatus), DBA::escape($diaspora), + DBA::escape(Protocol::ACTIVITYPUB), DBA::escape(Protocol::DFRN), DBA::escape($ostatus), DBA::escape($diaspora), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2))); $results = q("SELECT `nurl` FROM `gcontact` - WHERE NOT `hide` AND `network` IN ('%s', '%s', '%s') AND + WHERE NOT `hide` AND `network` IN ('%s', '%s', '%s', '%s') AND ((`last_contact` >= `last_failure`) OR (`updated` >= `last_failure`)) AND (`url` LIKE '%s' OR `name` LIKE '%s' OR `location` LIKE '%s' OR `addr` LIKE '%s' OR `about` LIKE '%s' OR `keywords` LIKE '%s') $extra_sql GROUP BY `nurl` ORDER BY `updated` DESC LIMIT %d, %d", - DBA::escape(Protocol::DFRN), DBA::escape($ostatus), DBA::escape($diaspora), + DBA::escape(Protocol::ACTIVITYPUB), DBA::escape(Protocol::DFRN), DBA::escape($ostatus), DBA::escape($diaspora), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), DBA::escape(Strings::escapeHtml($search2)), $pager->getStart(), $pager->getItemsPerPage()); diff --git a/src/Model/GContact.php b/src/Model/GContact.php index 6e2e520c8..1fed1fc3e 100644 --- a/src/Model/GContact.php +++ b/src/Model/GContact.php @@ -430,7 +430,7 @@ class GContact // return $list; //} - $network = [Protocol::DFRN]; + $network = [Protocol::DFRN, Protocol::ACTIVITYPUB]; if (Config::get('system', 'diaspora_enabled')) { $network[] = Protocol::DIASPORA; @@ -451,7 +451,7 @@ class GContact where uid = %d and not gcontact.nurl in ( select nurl from contact where uid = %d ) AND NOT `gcontact`.`name` IN (SELECT `name` FROM `contact` WHERE `uid` = %d) AND NOT `gcontact`.`id` IN (SELECT `gcid` FROM `gcign` WHERE `uid` = %d) - AND `gcontact`.`updated` >= '%s' + AND `gcontact`.`updated` >= '%s' AND NOT `gcontact`.`hide` AND `gcontact`.`last_contact` >= `gcontact`.`last_failure` AND `gcontact`.`network` IN (%s) GROUP BY `glink`.`gcid` ORDER BY `gcontact`.`updated` DESC,`total` DESC LIMIT %d, %d", From edc6ba976dbfe05fb143f458e3ff999e6570a4bf Mon Sep 17 00:00:00 2001 From: Michael Date: Tue, 13 Nov 2018 07:09:14 +0000 Subject: [PATCH 2/2] Output all technical fields - even for hidden contacts --- mod/noscrape.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mod/noscrape.php b/mod/noscrape.php index 0964e85ca..87367d536 100644 --- a/mod/noscrape.php +++ b/mod/noscrape.php @@ -36,6 +36,11 @@ function noscrape_init(App $a) 'account-type' => $a->profile['account-type'], ]; + $dfrn_pages = ['request', 'confirm', 'notify', 'poll']; + foreach ($dfrn_pages as $dfrn) { + $json_info["dfrn-{$dfrn}"] = System::baseUrl()."/dfrn_{$dfrn}/{$which}"; + } + if (!$a->profile['net-publish'] || $a->profile['hidewall']) { header('Content-type: application/json; charset=utf-8'); $json_info["hide"] = true; @@ -99,11 +104,6 @@ function noscrape_init(App $a) } } - $dfrn_pages = ['request', 'confirm', 'notify', 'poll']; - foreach ($dfrn_pages as $dfrn) { - $json_info["dfrn-{$dfrn}"] = System::baseUrl()."/dfrn_{$dfrn}/{$which}"; - } - //Output all the JSON! header('Content-type: application/json; charset=utf-8'); echo json_encode($json_info);