From 4ab75e2e8cb5e3c422d2c45e52a5a12d73ecfdbf Mon Sep 17 00:00:00 2001
From: Philipp Holzer <admin+github@philipp.info>
Date: Tue, 3 Sep 2019 18:37:27 +0200
Subject: [PATCH] Check twitter details before showing it

---
 twitter/twitter.php | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/twitter/twitter.php b/twitter/twitter.php
index eeee6cafc..d846b1ada 100644
--- a/twitter/twitter.php
+++ b/twitter/twitter.php
@@ -352,7 +352,10 @@ function twitter_settings(App $a, &$s)
 
 				$field_checkbox = Renderer::getMarkupTemplate('field_checkbox.tpl');
 
-				$s .= '<div id="twitter-info" >
+				if (property_exists($details, 'screen_name') &&
+				    property_exists($details, 'description') &&
+				    property_exists($details, 'profile_image_url')) {
+					$s .= '<div id="twitter-info" >
 					<p>' . L10n::t('Currently connected to: ') . '<a href="https://twitter.com/' . $details->screen_name . '" target="_twitter">' . $details->screen_name . '</a>
 						<button type="submit" name="twitter-disconnect" value="1">' . L10n::t('Disconnect') . '</button>
 					</p>
@@ -361,6 +364,12 @@ function twitter_settings(App $a, &$s)
 						<em>' . $details->description . '</em>
 					</p>
 				</div>';
+				} else {
+					$s .= '<div id="twitter-info" >
+					<p>Invalid Twitter info</p>
+				</div>';
+					Logger::info('Invalid twitter info (verify credentials).', ['auth' => TwitterOAuth::class]);
+				}
 				$s .= '<div class="clear"></div>';
 
 				$s .= Renderer::replaceMacros($field_checkbox, [