Merge pull request #11671 from MrPetovan/bug/fatal-errors

Add expected type-hint to BoundariesPager::renderFull
This commit is contained in:
Tobias Diekershoff 2022-06-22 14:30:39 +02:00 committed by GitHub
commit fa973d3b0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 5 deletions

View file

@ -130,7 +130,7 @@ class BoundariesPager extends Pager
return Renderer::replaceMacros($tpl, ['pager' => $data]);
}
public function renderFull(int $itemCount)
public function renderFull(int $itemCount): string
{
throw new \BadMethodCallException();
}

View file

@ -199,13 +199,13 @@ class Pager
*
* $html = $pager->renderFull();
*
* @param integer $itemCount The total number of items including those note displayed on the page
* @param int $itemCount The total number of items including those note displayed on the page
* @return string HTML string of the pager
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
public function renderFull(int $itemCount): string
{
$totalItemCount = max(0, intval($itemCount));
$totalItemCount = max(0, $itemCount);
$data = [];

View file

@ -1748,9 +1748,10 @@ class Database
* Fetch a database variable
*
* @param string $name
* @return string content
* @return string|null content or null if inexistent
* @throws \Exception
*/
public function getVariable(string $name): string
public function getVariable(string $name)
{
$result = $this->fetchFirst("SHOW GLOBAL VARIABLES WHERE `Variable_name` = ?", $name);
return $result['Value'] ?? null;