friendica/friendica
6
0
Fork 1
mirror of https://github.com/friendica/friendica synced 2024-05-23 23:44:58 +02:00
Code Issues Packages Projects Releases 1 Wiki Activity
39231 commits 2 branches 63 tags 241 MiB
Commit graph

731 commits

Author SHA1 Message Date
Hypolite Petovan dc90984106 Remove obsolete uses of Strings::escapeTags in mod/item 2020-09-13 20:01:55 -04:00
Hypolite Petovan 043e04f484 Remove confirm template obsolete uses (except for contacts) 
- Remove obsolete explode_querystring() function
- Remove $extra_inputs template variable
 2020-09-12 09:09:15 -04:00
Michael e6cd5a4d66 Merge remote-tracking branch 'upstream/develop' into personal-copy 2020-07-28 05:40:37 +00:00
Michael 0007da8630 EOL removed 2020-07-23 06:25:01 +00:00
Michael 3fc3ded750 Useless info messages removed 2020-07-23 06:11:21 +00:00
Michael ca9f8e7420 New function "Item::storeForUserByUriId" 2020-07-23 03:26:54 +00:00
Michael d0ef6f2b08 Store personal copy of public item upon commenting 2020-07-21 23:26:01 +00:00
Hypolite Petovan a13e004df0 Delete include/items.php 
- Remove all references
 2020-07-14 10:21:31 -04:00
Hypolite Petovan 3e25fc3a72 Replace *_page_info function calls with Content\PageInfo equivalent 2020-07-14 10:15:04 -04:00
Hypolite Petovan 416f6c8c10 Ensure $contact_record is an array in mod/item 2020-07-04 15:33:54 -04:00
Hypolite Petovan 6ead246ce2 Account for falsy values for $forum_contact in mod/item 
- Rare condition can make it false
- Simplify notification sending condition
 2020-07-04 15:33:35 -04:00
Hypolite Petovan f544c8383b Implement pull request feedback 
- Improve formatting of drop_item in mod/item
- Replace deprecated Logger::log() calls in Protocol\Feed::consume
 2020-06-17 21:44:28 -04:00
Hypolite Petovan 3d55ef1546 Move drop_items and drop_item out of include/items 
- They were only used in mod/item
 2020-06-17 13:24:44 -04:00
Hypolite Petovan f9ecbbd743 Exclude [img] tags from tag replacement 
- It broke image captions by inserting an HTML link inside an HTML attribute
 2020-06-16 16:34:16 -04:00
Michael Vogel 9b85d0b16e
Merge pull request #8740 from MrPetovan/task/frio-improve-share-display 
[frio] Improve share blocks display
 2020-06-11 07:32:29 +02:00
Hypolite Petovan 7b3581320b Add missing return variable while replacing tags in mod/item 2020-06-10 17:23:07 -04:00
Hypolite Petovan e7f50a05d1 Move handle_tag() to Content\Item::replaceTag 2020-06-10 10:13:32 -04:00
Hypolite Petovan 31d6a6157c Add tag escaping to tag handling in mod/item 2020-06-08 18:40:21 -04:00
Hypolite Petovan 76460ddd2d Add tag escaping to Item::setHashtags 
- Add return value to Item::setHashtags
 2020-06-08 18:40:21 -04:00
Hypolite Petovan d6fd5b273b Ensure $categories is set in mod/item 
- Address https://github.com/friendica/friendica/issues/8473#issuecomment-639052328
 2020-06-04 21:32:47 -04:00
Michael 973abb6196 Replace "id = parent" checks with "gravity" checks 2020-05-27 12:19:06 +00:00
Michael a1fc9df4ee Fix: Undefined index: uri-id in src/Model/Tag.php on line 403 2020-05-14 20:44:03 +00:00
Michael 258e9df064 Moved the check for a comment to a different place 2020-05-09 15:50:49 +00:00
Michael 221a659abe Unused variables removed 2020-05-09 09:38:49 +00:00
Michael 556cc3fb13 Always mention the parent author 2020-05-09 08:08:33 +00:00
Michael d5f64e1156 Issue 8610: Implicit mentions work again 2020-05-09 06:33:59 +00:00
Michael b0cb6536dd The old tag handling is removed 2020-05-02 05:08:05 +00:00
Michael 729c6b67aa the "term" field now is called "name", workaround removed 2020-05-01 15:18:48 +00:00
Michael 74081a71ff Removed unused "use" 2020-05-01 13:26:13 +00:00
Michael 029a379060 Move "isType" to Tag.php 2020-05-01 12:39:41 +00:00
Michael ac2957c4dd Some more "term" to "tag" conversion 2020-05-01 10:57:32 +00:00
Michael 7f5f68a904 More preparations for term to tag transition 2020-04-26 16:15:39 +00:00
Michael 3ff607deee Store tags for locally created posts 2020-04-15 19:46:47 +00:00
Hypolite Petovan 7fabafdce6 Enable visibility request parameter to override default user permissions in mod/item 2020-03-24 16:34:19 -04:00
Michael 8bde222fca Issue 8371: Use correct user id for photo upload 2020-03-22 14:07:34 +00:00
Michael 505aa95c3d Fixed wrong contact permisssion 2020-03-22 10:05:52 +00:00
Michael 6de2b0f6d4 Reworked permission stuff 2020-03-21 18:30:40 +00:00
Michael 2234a095c6 Issue 8371 again: Fallback for item permissions 2020-03-20 04:52:04 +00:00
Michael 29bd37cda2 Issue 8371: Ensure to always have permissions 2020-03-19 21:55:31 +00:00
Michael 31f912b78e Warning removed 2020-03-02 14:51:53 +00:00
Michael 4bf04dd6ee Fixed fatal error 2020-03-02 12:29:08 +00:00
Michael ca1b92bb34 Support unlisted public posts 2020-03-02 07:57:23 +00:00
Hypolite Petovan 0b0309ce8f Remove pager parameter from conversation() 
- Add getUrlParameter() Javascript function to determine current page
 2020-02-13 23:40:00 -05:00
nupplaPhil 85dc9bb96b
Add license info at Friendica PHP files 2020-02-09 16:18:46 +01:00
nupplaPhil e6fb044e60
Move Notify::TYPE_COMMENT 2020-02-05 21:41:02 +01:00
nupplaPhil b86ad37001
Move Notify::TYPE_WALL 2020-02-05 21:41:01 +01:00
Hypolite Petovan 3370300376 Add new info messages to mod/item 2020-01-29 22:45:13 -05:00
Hypolite Petovan b86083de06 Remove superfluous code in mod/item 2020-01-29 22:44:09 -05:00
Hypolite Petovan 4faad5a47c Replace exit calls with exception throwing in mod/item 2020-01-29 22:43:37 -05:00
Hypolite Petovan b03796957b Improve logging in mod/item 
- Set legacy Logger constants as deprecated
 2020-01-29 22:42:49 -05:00
Hypolite Petovan c17b2efb7a Normalize redirect in item_post() 2020-01-29 22:34:32 -05:00
Hypolite Petovan 694d93ded9 Replace json_encode + exit by System::jsonExit in mod/item 2020-01-29 22:31:13 -05:00
Philipp Holzer 2b8f067715
Introduce interface for emailing and create email classes 2020-01-26 21:35:04 +01:00
Philipp Holzer 915abe8a33
Add explicit parameters to Sender::send() method signature 2020-01-26 21:35:03 +01:00
Philipp Holzer ea9d3b7438
Make EMailer util dynamic 2020-01-26 21:35:03 +01:00
Philipp Holzer ed9392469e
Remove unneeded Config namespace usages 2020-01-19 22:50:44 +01:00
Philipp Holzer 6c36fd9e01
Move Config::get() to DI::config()->get() 2020-01-19 21:21:13 +01:00
Philipp Holzer d6efc90194
cleanup namespace usages for L10n 2020-01-19 16:31:33 +01:00
Philipp Holzer 5dfee31108
Move L10n::t() calls to DI::l10n()->t() calls 2020-01-19 16:31:16 +01:00
Philipp Holzer f0eea6f875
Remove get_app() in favor of DI::app() 2020-01-04 23:42:01 +01:00
Hypolite Petovan 52c5b0e0f3 Remove unused BBCode::scaleExternalImage parameters 
- Remove now obsolete system.no_view_full_size config key
 2020-01-02 20:44:15 -05:00
Hypolite Petovan 542e83137b Remove useless HTML encode on item save 2020-01-02 20:38:07 -05:00
Philipp Holzer 3f34229752
Move redundant System::baseUrl() to DI::baseUrl() calls 2019-12-30 23:00:08 +01:00
Philipp Holzer e6f61c2cc7
Remove deprecated App::query_string - replace with DI::args()->getQueryString() 2019-12-29 20:17:50 +01:00
Philipp Holzer 8b6e123b3f
Refactor deprecated App::isAjax() to DI::mode()->isAjax() 2019-12-29 20:17:44 +01:00
Philipp Holzer 8e6973b774
Refactor deprecated App::internalRedirect() to DI::baseUrl()->redirect() 2019-12-29 20:17:43 +01:00
Philipp Holzer 388b963714
Replace BaseObject class with DI::* calls 2019-12-29 20:17:38 +01:00
Michael 23cdc9cec8 Fixes issue 7914: Reshares got crumbled 2019-12-07 21:05:14 +00:00
Michael 22c66e1811 Add data for shared posts from the original 2019-12-04 22:57:09 +00:00
Philipp Holzer 3897c74deb
Add docs 2019-10-25 00:10:20 +02:00
Philipp Holzer 07cea24430
Move Activity/Namespaces defines to constants 2019-10-24 21:40:12 +02:00
Philipp Holzer c9e1098dd2
Adapt naming convention 2019-10-23 21:39:00 +02:00
Philipp Holzer 5843a80b6c
Move perms2str to ACLFormatter::aclToString() 
- including new tests
 2019-10-23 00:54:34 +02:00
Philipp Holzer 2870f42ca2
Move bb_translate_video 
- To new Class BBCode\Video
- Adding tests
- Make BaseObject::getClass() public
 2019-10-23 00:14:47 +02:00
Hypolite Petovan e3915d2f93 Prevent empty [url] label regular expression to break image insertion 2019-10-16 13:53:16 -04:00
Philipp b0967ffd02
Merge pull request #7742 from MrPetovan/task/7190-remove-defaults-mod 
Replace deprecated defaults() calls by a combination of ?? and ?: operators in mod/
 2019-10-15 18:07:53 +02:00
Hypolite Petovan 2db6171641 Replace deprecated defaults() calls by a combination of ?? and ?: operators in mod/ 2019-10-15 09:01:17 -04:00
Michael 5875830d1e Convert links with empty descriptions 2019-10-13 15:52:33 +00:00
Hypolite Petovan 2333526b8a
Merge pull request #7678 from annando/remote-rework 
Reworked the remote authentication
 2019-09-30 09:18:43 -04:00
Philipp Holzer d5dd12b8f8
Add Drone CI 
- Add drone test environment
- Add drone config
- apt phpunit
- Fix api.php
- Fix item.php
- Fix DBStructure
- Check if caching is possible during tests
 2019-09-30 14:03:12 +02:00
Michael 83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
Michael 1c26baec46 remote_user is replaced 2019-09-28 09:59:08 +00:00
Michael ec66553032 Reworked "remote" cookie handling 2019-09-25 22:24:17 +00:00
Michael 1144863090 Changed "hidewall" behaviour 2019-09-18 05:20:33 +00:00
Michael Vogel 35a487ae30 Don't fork worker on frontend by default 2019-08-08 22:42:12 +02:00
Michael d95ef96cca Fix issue 7449: Image permissions are now set like before 2019-08-02 16:38:50 +00:00
Michael 6041f74df6 New constant for federated protocols 2019-07-01 18:00:55 +00:00
Michael 41dc243186 Fix delivery counter for poking / unify delivery commands 2019-06-10 14:19:24 +00:00
Michael 44a49a8d7d Ensure that pokes are always send only via DFRN 2019-06-06 04:26:02 +00:00
Philipp Holzer c76258c370
catching nulls for FileTag 2019-05-30 13:54:35 +02:00
Hypolite Petovan 0fadc7730c Replace deprecated string-bases Model\FileTag calls with array-based ones 2019-05-27 17:40:08 -04:00
Hypolite Petovan 67aa188830 Improve Logger calls 
- Add context in various calls
- Remove deprecated Logger::log call in Processor
 2019-02-23 17:32:13 -05:00
Hypolite Petovan c7dfc88c6c Add implicit mention gathering in local posts 
- Rename $parent_item to $toplevel_item in item_post()
- Add $thread_parent_id variable to distinguish from $parent_item
- Add item_add_implicit_mentions() function
 2019-02-23 17:32:12 -05:00
Hypolite Petovan 8c1db51a76 Improve Logger calls 
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
 2019-02-23 17:32:11 -05:00
rabuzarus a6322b1c4e attachment preview: some backend work in the item module: 
- convert attachment to bbcode and
- add the attachment bbcode to the item body
 2019-02-01 23:42:36 +01:00
Hypolite Petovan 7f2dc40601 Fix potential bugs without expected behavior change 
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
 2019-01-21 11:04:19 -05:00
Hypolite Petovan dbc6eb5422 Remove unused code in mod/ 
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
 2019-01-21 10:53:32 -05:00
Hypolite Petovan 070aa016e0 Update more PHPDoc, including in include/ 2019-01-21 10:39:28 -05:00
Hypolite Petovan af9067a381 Update PHPDoc in mod/ 2019-01-21 10:39:27 -05:00
fabrixxm 14622c4bfd Use more Attach model 2019-01-21 10:00:47 -05:00
Hypolite Petovan 55e54bb950 Replace deprecated Addon::callHooks with Hook::callAll 
- Update documentation
 2019-01-21 09:50:56 -05:00
Hypolite Petovan 895b3abf32 Remove/replace killme() with *exit() 2019-01-21 09:49:17 -05:00
Hypolite Petovan dea1a98a5d Fix various documentation issues/unused variables 2019-01-21 09:33:24 -05:00
fabrixxm 55292c954b Remove resourceid parameter from Photo::exists() 2019-01-21 09:12:29 -05:00
fabrixxm 8c75c26361 Use Model\Photo as much as possible 
Most important is to use `Photo::delete()` to have backend
to remove data.
 2019-01-21 09:12:28 -05:00
Hypolite Petovan 5e1ceb57de Escape global namespaced get_app() calls 
- Add deprecated status
 2019-01-03 21:27:36 -05:00
Hypolite Petovan acaee626f5 Remove include/ requires that are now done directly from Composer 2018-12-24 09:56:25 -05:00
Hypolite Petovan 458981f75c Replace x() by isset(), !empty() or defaults() 
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
 2018-11-30 09:06:22 -05:00
Jonny Tischbein 7c690c93bb Fix setting permisson as post for uploaded photo in album via modal create post 2018-11-17 19:14:59 +01:00
Adam Magness 218f0734be Rename removeTags to escapeTags 
rename function and update calls.
 2018-11-09 13:29:42 -05:00
Adam Magness 063f0e9cb0 Rename escapeTags to escapeHtml 
rename function and update calls.
 2018-11-09 13:27:58 -05:00
Adam Magness b5a97c1abe Move getTags to BBCode 
move getTags function to BBCode class and update calls.
 2018-11-09 13:24:19 -05:00
Adam Magness 5276c28a78 link_compare calls 
implement compareLink function.
 2018-11-08 10:46:50 -05:00
Adam Magness 0e01568ccd escape_tags calls 
implement escapeTags function
 2018-11-08 10:20:03 -05:00
Adam Magness a0f65ca7a1 notags calls 
implement removeTags function
 2018-11-08 10:14:37 -05:00
Adam Magness e537f7d017 Function calls 
update function calls to new class
 2018-11-06 21:16:27 -05:00
Michael 1b43d459b6 Fix for delivering forum posts again 2018-11-01 23:52:06 +00:00
Jonny Tischbein 6b43174a74 Fix for vier theme / NonAjax Call 2018-10-31 20:09:44 +01:00
Jonny Tischbein b66bcb20da Redirect to previous page after NON-AJAX Post delete via second parameter in /item/drop 2018-10-31 20:09:44 +01:00
Adam Magness d9b558a8ed Update function calls 
update function calls to new class.
 2018-10-30 14:51:45 -04:00
Adam Magness 50da89d861 Logger Levels 
update logger levels in calls
 2018-10-30 09:58:45 -04:00
Adam Magness 14fde5dc9b Log function 
implement log() function.
 2018-10-30 09:57:14 -04:00
Michael 84be62982a Diaspora signature transport via AP/DFRN should be repaired now 2018-10-29 21:15:37 +00:00
Hypolite Petovan 933f43218a
Merge pull request #6037 from annando/ap-signatures 
Diaspora signatures are now stored and transmitted correctly
 2018-10-27 13:49:19 -04:00
Michael 4831688dc0 Diaspora signatures are now stored and transmitted correctly 2018-10-27 14:35:22 +00:00
Hypolite Petovan de6b640483
Remove extra use statement in mod/item 
Fix #6036
 2018-10-27 09:54:38 -04:00
Michael 73f596cc46 Fixes duplicated transmissions and not working undo of like/dislike 2018-10-27 11:09:23 +00:00
Hypolite Petovan 14237a9599 Move $pager and $page_offset out of App 
- Move infinite scroll data output in a module hook
- Use Pager instead of paginate() and alt_pager()
 2018-10-25 00:07:15 -04:00
Philipp Holzer d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect() 2018-10-22 22:13:35 +02:00
Philipp Holzer 2ef81108b3
Renamed System::redirect() to $a->redirect() 2018-10-22 22:13:22 +02:00
Hypolite Petovan ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security 
Move and Split include/security
 2018-10-19 08:55:08 -04:00
Jonny Tischbein f3fc1f36ca Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments 2018-10-17 21:30:41 +02:00
Jonny Tischbein 45e5a7f59f remove unsed require_onces of security.php 2018-10-17 18:39:27 +02:00
Jonny Tischbein 05be2db725 Move include/security tp /src/Core/Authentication and /src/Util/Security 2018-10-17 14:19:58 +02:00
Hypolite Petovan 45748da8a1 Remove network exception in handle_tag 2018-10-17 01:11:50 -04:00
Philipp Holzer 2c541afd47
Moved functions out of boot.php into class 
- z_root() => $a->getBaseURL()
- absurl() => removed because no usage
- is_ajax() => $a->isAjax()
- current_load() => System::currentLoad()
- argc() => $a->argc
- argv($x) => $a->getArgumentValue($x)
 2018-10-13 19:03:08 +02:00
Michael 7e9499ac13 AP contacts are now tagged upon commenting 2018-10-01 21:09:08 +00:00
Michael 93ccca5807 AP hast to be enabled here as well 2018-09-30 21:23:40 +00:00
Michael cb9be8a7ab UUID is now createUUID 2018-09-27 11:52:15 +00:00
Michael 60b0759b50 UUID instead of GUID 2018-09-26 20:03:46 +00:00
Michael 4bb45f611f Fix for timeout issues when posting to the API 2018-09-02 07:20:04 +00:00
Michael e8334c4655 Use the Item class instead of DBA calls when possible 2018-08-15 04:41:49 +00:00
Michael Vogel 880b7177c8 And again, and again, and again, ... some more notices removed (#5601) 
* And again, and again, and again, ... some more notices removed

* And some more notices ...

* Some more place
 2018-08-11 23:05:42 +02:00
Roland Häder e06fc2aa69 Stopped using deprecated constants NETWORK_* (#5537) 
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...

* Removed deprecated NETWORK_* constants as per code reviewer's request.
 2018-08-11 22:40:44 +02:00
Michael Vogel 8c2efa6df4 Facebook and App.net is removed from nearly all places (#5581) 
* Facebook is removed from nearly all places

* Remove app.net as well - it's dead for some time now
 2018-08-07 17:06:51 +02:00
Hypolite Petovan c13dc549ed Rename PROTOCOL_* constants to Model\Conversation::PARCEL_* 
- Remove unused Conversation::PROTOCOL_GS_CONVERSATION constant
- Remove now renamed PROTOCOL_* constant declarations
 2018-08-05 12:24:42 +02:00
Michael Vogel 810c108297 Fix: Notes can be posted again. Never use "defaults" with "false" (#5551) 2018-08-04 16:06:36 +02:00
Roland Häder cff90e20f2 Removal of x() and added missing columns of contact (#5479) 
* Fixes:
- got rid of x() in whole mod/item.php file
- added missing 'prv' and 'forum' columns, maybe one day, let's rewrite this
  again. it is kinda a maintenance nightmare, keeping up with column renames and
  such. Well, for now it should be okay.

* Should be DBA::isResult()
 2018-07-24 17:48:47 -04:00
Hypolite Petovan ecea7425f8 Rename DBA::is_result to DBA::isResult 2018-07-23 11:04:14 -04:00
Hypolite Petovan 0ec44f3e8a Rename DBM method calls to DBA method calls 2018-07-23 11:02:24 -04:00