friendica/friendica-addons
7
2
Fork 13
Code Issues 3 Pull requests 2 Releases 16 Wiki Activity

Extending the Unicode Emoji based on the 'unicode_smiles addon' #937

Merged
loma-one merged 6 commits from patch-1 into develop 2020-01-02 21:55:11 +01:00
Conversation 4 Commits 6 Files changed 1 +1780 -11
loma-one commented 2020-01-01 18:44:34 +01:00 (Migrated from github.com)
Copy link

Extending the Unicode Emoji based on the 'unicode_smiles addon'

Extending the Unicode Emoji based on the 'unicode_smiles addon'
MrPetovan (Migrated from github.com) requested changes 2020-01-02 00:15:10 +01:00
MrPetovan (Migrated from github.com) left a comment
Copy link

Please restore the indentation of the file, many lines have been yanked to the left. Comments should also be on the same indentation level as the code.

Please restore the indentation of the file, many lines have been yanked to the left. Comments should also be on the same indentation level as the code.
tobiasd (Migrated from github.com) reviewed 2020-01-02 06:48:01 +01:00
tobiasd (Migrated from github.com) reviewed 2020-01-02 06:50:21 +01:00
tobiasd (Migrated from github.com) reviewed 2020-01-02 06:52:15 +01:00
tobiasd (Migrated from github.com) reviewed 2020-01-02 06:57:04 +01:00
tobiasd (Migrated from github.com) reviewed 2020-01-02 06:59:46 +01:00
loma-one commented 2020-01-02 10:15:57 +01:00 (Migrated from github.com)
Copy link

The changes have been made. I hope this fits.
The changes are probably available as "loma-one:patch-1". I don't know if that's right.

The changes have been made. I hope this fits. The changes are probably available as "loma-one:patch-1". I don't know if that's right.
annando commented 2020-01-02 10:52:14 +01:00 (Migrated from github.com)
Copy link

The indentation should be a single tab. Can you also have a look at the things that @tobiasd pointed out?

The indentation should be a single tab. Can you also have a look at the things that @tobiasd pointed out?
loma-one commented 2020-01-02 10:58:31 +01:00 (Migrated from github.com)
Copy link

The hints of @tobiasd were also considered.

hmm... the processing is done with Kate. Then I copy the content using the git editor.

The entries in Kate actually look good to me.

UNICODE Vergleich

The hints of @tobiasd were also considered. hmm... the processing is done with Kate. Then I copy the content using the git editor. The entries in Kate actually look good to me. ![UNICODE Vergleich](https://user-images.githubusercontent.com/44441246/71674378-52b45a00-2d7b-11ea-9c3f-0c0759f105b2.png)
loma-one (Migrated from github.com) reviewed 2020-01-02 11:29:03 +01:00
loma-one (Migrated from github.com) reviewed 2020-01-02 11:29:27 +01:00
loma-one (Migrated from github.com) reviewed 2020-01-02 11:29:40 +01:00
loma-one (Migrated from github.com) reviewed 2020-01-02 11:30:36 +01:00
loma-one (Migrated from github.com) reviewed 2020-01-02 11:31:30 +01:00
MrPetovan (Migrated from github.com) requested changes 2020-01-02 13:45:35 +01:00
MrPetovan (Migrated from github.com) left a comment
Copy link

And now it's been yanked one level to the right ! 😅

What editor are you using? It may be a configuration issue.

And now it's been yanked one level to the right ! 😅 What editor are you using? It may be a configuration issue.
MrPetovan (Migrated from github.com) reviewed 2020-01-02 14:18:29 +01:00
MrPetovan (Migrated from github.com) reviewed 2020-01-02 16:45:02 +01:00
MrPetovan (Migrated from github.com) left a comment
Copy link

Thanks for fixing the indentation, I have a few more questions.

Thanks for fixing the indentation, I have a few more questions.
loma-one (Migrated from github.com) reviewed 2020-01-02 21:32:12 +01:00
loma-one (Migrated from github.com) reviewed 2020-01-02 21:34:25 +01:00
loma-one (Migrated from github.com) reviewed 2020-01-02 21:37:16 +01:00
MrPetovan (Migrated from github.com) reviewed 2020-01-02 21:38:23 +01:00
MrPetovan (Migrated from github.com) reviewed 2020-01-02 21:38:51 +01:00
MrPetovan (Migrated from github.com) requested changes 2020-01-02 21:47:37 +01:00
MrPetovan (Migrated from github.com) left a comment
Copy link

Please change wales to :wales and precise why there's a duplicate to understand if it needs to changed or removed.

Please change `wales` to `:wales` and precise why there's a duplicate to understand if it needs to changed or removed.
MrPetovan (Migrated from github.com) approved these changes 2020-01-02 21:54:50 +01:00
MrPetovan commented 2020-01-02 21:55:01 +01:00 (Migrated from github.com)
Copy link

Thanks for your patience!

Thanks for your patience!
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No labels
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#937
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?